fix(deploy): add CORS origins env var to API deployment#451
Merged
Conversation
The ConfigMap had the CORS origins but the API deployment never read the key — it was missing from the container's env spec. OPTIONS preflight requests returned 405 because the CORS middleware was never initialized. Marked optional so local/dev deployments without CORS config still work (CORS disabled by default when origins list is empty). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA new environment variable Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jsell-rh
added a commit
that referenced
this pull request
May 2, 2026
) The ConfigMap had the CORS origins but the API deployment never read the key — it was missing from the container's env spec. OPTIONS preflight requests returned 405 because the CORS middleware was never initialized. Marked optional so local/dev deployments without CORS config still work (CORS disabled by default when origins list is empty). Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jsell-rh
added a commit
that referenced
this pull request
May 2, 2026
) The ConfigMap had the CORS origins but the API deployment never read the key — it was missing from the container's env spec. OPTIONS preflight requests returned 405 because the CORS middleware was never initialized. Marked optional so local/dev deployments without CORS config still work (CORS disabled by default when origins list is empty). Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CORS origins were in the ConfigMap but the API deployment never read the key —
KARTOGRAPH_CORS_ORIGINSwas missing from the container's env spec. The CORS middleware never initialized, causing OPTIONS preflight requests to return 405.Adds
configMapKeyRefforKARTOGRAPH_CORS_ORIGINSwithoptional: trueso deployments without CORS config still work.🤖 Generated with Claude Code
Summary by CodeRabbit